Workflow validation #1223
Workflow validation #1223
Conversation
workflow/workflow.go
Outdated
| return fmt.Errorf("non connected graph") | ||
| } | ||
| if !w.isMonoParental() { | ||
| return fmt.Errorf("non mono-parental graph") |
There was a problem hiding this comment.
I've never see a mono-parental word to describe a graph, can you point out the article/algorithm where they use such terminology?
| return fmt.Errorf("non mono-parental graph") | |
| return fmt.Errorf("the edge %s has to or more parents") |
Also, a method name can be changed.
There was a problem hiding this comment.
This is not the right term, I couldn't find a better name. If you know any name that describes that each node should have only one parent I'm really happy to change this
There was a problem hiding this comment.
changed the function to maximumParentNode(max int) that returns true when all the nodes have less than max parents.
Co-Authored-By: krhubert <[email protected]>
I agree that's why I started to move all the graph-related stuff in the algorithm file. I don't want to charge too much this PR and also I have to have a look at https://github.com/gonum/gonum/tree/master/graph that might replace all. So this will certainly change soon. |
antho1404
force-pushed
the
feature/workflow-validation
branch
from
1f81955
to
a15be27
Compare
antho1404
force-pushed
the
feature/workflow-validation
branch
from
14a43ff
to
cf7966d
Compare
Co-Authored-By: Nicolas Mahé <[email protected]>
Add workflow validation:
With this validation, we are allowing only directed tree graphs which is a family of DAG.
You can use the test from this PR: #1209